Discussion:
[MPlayer-users] Build error MinGW/VCD
Josh
2015-08-29 17:40:24 UTC
Permalink
I'm unable to build with VCD enabled in the latest SVN under
MinGW-w64/GCC 4.9.3. I am using libcdio 0.93/paranoia 10.2+0.93. I was
using 0.83 thinking that was the problem but updating to 0.93 didn't
change anything. Here are the log files if they are needed:
http://mplayerwin.sourceforge.net/misc/mpl-bin-r37465/buildinfo/

stream/stream_vcd.c: In function 'close_s':
stream/stream_vcd.c:131:3: error: implicit declaration of function
'cdio_destroy' [-Werror=implicit-function-declaration]
cdio_destroy(vcd->cdio);
^
stream/stream_vcd.c:131:19: error: 'mp_vcd_priv_t' has no member named
'cdio'
cdio_destroy(vcd->cdio);
^
stream/stream_vcd.c: In function 'open_s':
stream/stream_vcd.c:154:3: error: unknown type name 'CdIo'
CdIo *cdio;
^
stream/stream_vcd.c:211:8: error: 'mp_vcd_priv_t' has no member named 'cdio'
vcd->cdio = cdio;
^
cc1.exe: some warnings being treated as errors
Makefile:731: recipe for target 'stream/stream_vcd.o' failed
make: *** [stream/stream_vcd.o] Error 1
Roberto Togni
2015-08-29 19:37:10 UTC
Permalink
On Sat, 29 Aug 2015 13:40:24 -0400
Post by Josh
I'm unable to build with VCD enabled in the latest SVN under
MinGW-w64/GCC 4.9.3. I am using libcdio 0.93/paranoia 10.2+0.93. I was
using 0.83 thinking that was the problem but updating to 0.93 didn't
http://mplayerwin.sourceforge.net/misc/mpl-bin-r37465/buildinfo/
stream/stream_vcd.c:131:3: error: implicit declaration of function
'cdio_destroy' [-Werror=implicit-function-declaration]
cdio_destroy(vcd->cdio);
^
stream/stream_vcd.c:131:19: error: 'mp_vcd_priv_t' has no member named
'cdio'
cdio_destroy(vcd->cdio);
^
stream/stream_vcd.c:154:3: error: unknown type name 'CdIo'
CdIo *cdio;
^
stream/stream_vcd.c:211:8: error: 'mp_vcd_priv_t' has no member named 'cdio'
vcd->cdio = cdio;
^
cc1.exe: some warnings being treated as errors
Makefile:731: recipe for target 'stream/stream_vcd.o' failed
make: *** [stream/stream_vcd.o] Error 1
The attached patch may fix it for you, but it's probably not the best
fix (you lose the new functionalities about playing video CDs with
libcdio, even if I have no idea if that may work in Windows).


Please test, if it works I will commit it while waiting for a bet fix.

Ciao,
Roberto
Josh
2015-08-30 01:11:14 UTC
Permalink
Post by Roberto Togni
On Sat, 29 Aug 2015 13:40:24 -0400
Post by Josh
I'm unable to build with VCD enabled in the latest SVN under
MinGW-w64/GCC 4.9.3. I am using libcdio 0.93/paranoia 10.2+0.93. I was
using 0.83 thinking that was the problem but updating to 0.93 didn't
http://mplayerwin.sourceforge.net/misc/mpl-bin-r37465/buildinfo/
stream/stream_vcd.c:131:3: error: implicit declaration of function
'cdio_destroy' [-Werror=implicit-function-declaration]
cdio_destroy(vcd->cdio);
^
stream/stream_vcd.c:131:19: error: 'mp_vcd_priv_t' has no member named
'cdio'
cdio_destroy(vcd->cdio);
^
stream/stream_vcd.c:154:3: error: unknown type name 'CdIo'
CdIo *cdio;
^
stream/stream_vcd.c:211:8: error: 'mp_vcd_priv_t' has no member named 'cdio'
vcd->cdio = cdio;
^
cc1.exe: some warnings being treated as errors
Makefile:731: recipe for target 'stream/stream_vcd.o' failed
make: *** [stream/stream_vcd.o] Error 1
The attached patch may fix it for you, but it's probably not the best
fix (you lose the new functionalities about playing video CDs with
libcdio, even if I have no idea if that may work in Windows).
Please test, if it works I will commit it while waiting for a bet fix.
Ciao,
Roberto
_______________________________________________
MPlayer-users mailing list
https://lists.mplayerhq.hu/mailman/listinfo/mplayer-users
Compiled successfully.

I have no idea if VCDs even work since I don't have any but it is
autodetected by configure as being supported, after fixing header paths
which aren't correct for MinGW-w64 anyway:

http://mplayerwin.sourceforge.net/misc/0012-vcd-support-on-MinGW-w64.patch
http://mplayerwin.sourceforge.net/misc/0011-stream_cddb-fix-include-path-on-MinGW-w64.patch
Ingo Brückl
2015-08-30 09:44:48 UTC
Permalink
Post by Roberto Togni
On Sat, 29 Aug 2015 13:40:24 -0400
Post by Josh
I'm unable to build with VCD enabled in the latest SVN under
MinGW-w64/GCC 4.9.3.
stream/stream_vcd.c:131:3: error: implicit declaration of function
'cdio_destroy' [-Werror=implicit-function-declaration]
cdio_destroy(vcd->cdio);
^
The attached patch may fix it for you, but it's probably not the best
fix (you lose the new functionalities about playing video CDs with
libcdio, even if I have no idea if that may work in Windows).
I also have no idea and can't test in Windows.
Post by Roberto Togni
Index: stream_vcd.c
===================================================================
+++ stream_vcd.c (copia locale)
@@ -40,12 +40,16 @@
#if defined(__FreeBSD__) || defined(__FreeBSD_kernel__) ||
defined(__DragonFly__) || defined(__NetBSD__) || defined(__OpenBSD__)
#include "vcd_read_fbsd.h"
+#undef CONFIG_LIBCDIO
#elif defined(__APPLE__)
#include "vcd_read_darwin.h"
+#undef CONFIG_LIBCDIO
#elif defined(__MINGW32__) || defined(__CYGWIN__)
#include "vcd_read_win32.h"
+#undef CONFIG_LIBCDIO
#elif defined(__OS2__)
#include "vcd_read_os2.h"
+#undef CONFIG_LIBCDIO
#elif CONFIG_LIBCDIO
#include "vcd_read_libcdio.h"
#else
Either this, or we prefer libcdio if detected - please see patch. (I'd
suspect libcdio to work if it is available for fbsd, darwin, win32 or os2.)

Ingo
Josh
2015-08-30 19:50:13 UTC
Permalink
Post by Ingo Brückl
Post by Roberto Togni
On Sat, 29 Aug 2015 13:40:24 -0400
Post by Josh
I'm unable to build with VCD enabled in the latest SVN under
MinGW-w64/GCC 4.9.3.
stream/stream_vcd.c:131:3: error: implicit declaration of function
'cdio_destroy' [-Werror=implicit-function-declaration]
cdio_destroy(vcd->cdio);
^
The attached patch may fix it for you, but it's probably not the best
fix (you lose the new functionalities about playing video CDs with
libcdio, even if I have no idea if that may work in Windows).
I also have no idea and can't test in Windows.
Post by Roberto Togni
Index: stream_vcd.c
===================================================================
+++ stream_vcd.c (copia locale)
@@ -40,12 +40,16 @@
#if defined(__FreeBSD__) || defined(__FreeBSD_kernel__) ||
defined(__DragonFly__) || defined(__NetBSD__) || defined(__OpenBSD__)
#include "vcd_read_fbsd.h"
+#undef CONFIG_LIBCDIO
#elif defined(__APPLE__)
#include "vcd_read_darwin.h"
+#undef CONFIG_LIBCDIO
#elif defined(__MINGW32__) || defined(__CYGWIN__)
#include "vcd_read_win32.h"
+#undef CONFIG_LIBCDIO
#elif defined(__OS2__)
#include "vcd_read_os2.h"
+#undef CONFIG_LIBCDIO
#elif CONFIG_LIBCDIO
#include "vcd_read_libcdio.h"
#else
Either this, or we prefer libcdio if detected - please see patch. (I'd
suspect libcdio to work if it is available for fbsd, darwin, win32 or os2.)
Ingo
_______________________________________________
MPlayer-users mailing list
https://lists.mplayerhq.hu/mailman/listinfo/mplayer-users
Also builds successfully with Ingo's patch.

Loading...